util: Remove the inline attribute #2439
Merged
+8
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding the inline keyword to a weak function results in the symbol to not actually be defined as weak. Thus, the compilation will fail for platforms which define their own version of those functions (FreeRTOS for example). __attribute__((weak)) inline: arm-none-eabi-nm build/objs/iio_demo_freeRTOS/build/app/noos/util/no_os_semaphore.o 00000000 T no_os_semaphore_give 00000000 T no_os_semaphore_init 00000000 T no_os_semaphore_remove 00000000 T no_os_semaphore_take __attribute__((weak)): arm-none-eabi-nm build/objs/iio_demo_freeRTOS/build/app/noos/util/no_os_mutex.o 00000000 W no_os_mutex_init 00000000 W no_os_mutex_lock 00000000 W no_os_mutex_remove 00000000 W no_os_mutex_unlock 00000000 n wm4.0.2fb1d36208757ad46d380e25c322250d Signed-off-by: Ciprian Regus <[email protected]>
CiprianRegus
requested review from
buha,
dbogdan,
amiclaus,
rbolboac and
danmois
as code owners
buha
approved these changes
Feb 7, 2025
amiclaus
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the inline keyword to a weak function results in the symbol to not actually be defined as weak. Thus, the compilation will fail for platforms which define their own version of those functions (FreeRTOS for example).
attribute((weak)) inline:
arm-none-eabi-nm build/objs/iio_demo_freeRTOS/build/app/noos/util/no_os_semaphore.o 00000000 T no_os_semaphore_give
00000000 T no_os_semaphore_init
00000000 T no_os_semaphore_remove
00000000 T no_os_semaphore_take
attribute((weak)):
arm-none-eabi-nm build/objs/iio_demo_freeRTOS/build/app/noos/util/no_os_mutex.o 00000000 W no_os_mutex_init
00000000 W no_os_mutex_lock
00000000 W no_os_mutex_remove
00000000 W no_os_mutex_unlock
00000000 n wm4.0.2fb1d36208757ad46d380e25c322250d
Pull Request Description
Please replace this with a detailed description and motivation of the changes.
You can tick the checkboxes below with an 'x' between square brackets or just check them after publishing the PR.
If this PR contains a breaking change, list dependent PRs and try to push all related PRs at the same time.
PR Type
PR Checklist