-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
README_BUILD.md : update #798
Conversation
1dd343a
to
ae7c735
Compare
analog@precision:~$ cd libini | ||
analog@precision:~/libini$ mkdir build && cd build && cmake ../ && make && sudo make install | ||
``` | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why remove this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
libini is now included in the libiio repo, and this step isn't required anymore.
https://github.com/analogdevicesinc/libiio/tree/master/libini
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright.
README_BUILD.md
Outdated
``` | ||
It will try to link against the `call_function` symbol even though it's clearly dead code. | ||
|
||
For this reason, when building with MSVC, please build in `RelWithDebInfo` mode. If you tryt o build in `Debug` mode, it will error. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tryt o
-> try to
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed - thanks for reviewing.
Add the list of missing features/and note about MSVC. Signed-off-by: Robin Getz <[email protected]>
ae7c735
to
539b59b
Compare
Add the list of missing features/and note about MSVC.
Signed-off-by: Robin Getz [email protected]