Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README_BUILD.md : update #798

Merged
merged 1 commit into from
Feb 22, 2022
Merged

Conversation

rgetz
Copy link
Contributor

@rgetz rgetz commented Feb 21, 2022

Add the list of missing features/and note about MSVC.

Signed-off-by: Robin Getz [email protected]

@rgetz rgetz mentioned this pull request Feb 21, 2022
@rgetz rgetz force-pushed the rgetz-update-build-instructions branch from 1dd343a to ae7c735 Compare February 22, 2022 01:54
analog@precision:~$ cd libini
analog@precision:~/libini$ mkdir build && cd build && cmake ../ && make && sudo make install
```

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

libini is now included in the libiio repo, and this step isn't required anymore.

https://github.com/analogdevicesinc/libiio/tree/master/libini

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright.

README_BUILD.md Outdated
```
It will try to link against the `call_function` symbol even though it's clearly dead code.

For this reason, when building with MSVC, please build in `RelWithDebInfo` mode. If you tryt o build in `Debug` mode, it will error.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tryt o -> try to

Copy link
Contributor Author

@rgetz rgetz Feb 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed - thanks for reviewing.

Add the list of missing features/and note about MSVC.

Signed-off-by: Robin Getz <[email protected]>
@rgetz rgetz force-pushed the rgetz-update-build-instructions branch from ae7c735 to 539b59b Compare February 22, 2022 14:43
@pcercuei pcercuei self-requested a review February 22, 2022 14:58
@pcercuei pcercuei merged commit 70a5839 into master Feb 22, 2022
@pcercuei pcercuei deleted the rgetz-update-build-instructions branch February 22, 2022 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants