Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

c#: Add new channel type entry (attention) #1232

Merged
merged 4 commits into from
Jan 29, 2025

Conversation

dNechita
Copy link
Contributor

PR Description

Keep the channel types from the C# bindings in sync with the ones within the libiio library.

PR Type

  • Bug fix (a change that fixes an issue)
  • New feature (a change that adds new functionality)
  • Breaking change (a change that affects other repos or cause CIs to fail)

PR Checklist

  • I have conducted a self-review of my own code changes
  • I have commented new code, particulary complex or unclear areas
  • I have checked that I did not intoduced new warnings or errors (CI output)
  • I have checked that components that use libiio did not get broken
  • I have updated the documentation accordingly (GitHub Pages, READMEs, etc)

@rgetz
Copy link
Contributor

rgetz commented Jan 22, 2025

You may want to update ./CI/azure/check_kernel.sh to check bindings/csharp/Channel.cs and bindings/python/iio.py so we don't forget to this in the future. Nothing like getting a reminder to fix something. :)

@dNechita
Copy link
Contributor Author

You may want to update ./CI/azure/check_kernel.sh to check bindings/csharp/Channel.cs and bindings/python/iio.py so we don't forget to this in the future. Nothing like getting a reminder to fix something. :)

A true pleasure indeed :)
I have put up checks for both C# and Python that should enforce keeping everything in sync. Thanks for suggesting it!

@dNechita dNechita force-pushed the csharp_update_channel_types branch from a4d6641 to 17bc457 Compare January 27, 2025 09:55
@cristina-suteu cristina-suteu merged commit eb401ec into main Jan 29, 2025
22 of 23 checks passed
@cristina-suteu cristina-suteu deleted the csharp_update_channel_types branch January 29, 2025 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants