coverity: fix dns_sd.c Resource leak

CID 355432 (#2 of 2): Resource leak (RESOURCE_LEAK) 3. leaked_storage: Variable ddata going out of scope leaks the storage it points to. Ensure we free anything that was allocated Signed-off-by: Robin Getz <[email protected]>
analogdevicesinc · Apr 3, 2020 · e284750 · e284750
1 parent 332ecdb
commit e284750
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/dns_sd.c b/dns_sd.c
@@ -249,11 +249,13 @@ int dnssd_context_scan(struct iio_scan_backend_context *ctx,
 	ret = dnssd_find_hosts(&ddata);
 
 	/* if we return an error when no devices are found, then other scans will fail */
-	if (ret == -ENXIO)
-		return 0;
+	if (ret == -ENXIO) {
+		ret = 0;
+		goto fail;
+	}
 
 	if (ret < 0)
-		return ret;
+		goto fail;
 
 	for (ndata = ddata; ndata->next != NULL; ndata = ndata->next) {
 		info = iio_scan_result_add(scan_result, 1);
@@ -271,6 +273,7 @@ int dnssd_context_scan(struct iio_scan_backend_context *ctx,
 		}
 	}
 
+fail:
 	dnssd_free_all_discovery_data(ddata);
 	return ret;
 }