Coverity: fix Call to function atoi with tainted argument

by using a different function that does better errror handling. Signed-off-by: Robin Getz <[email protected]>
analogdevicesinc · Apr 8, 2020 · e12120a · e12120a
1 parent 23ab5d8
commit e12120a
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/tests/iio_stresstest.c b/tests/iio_stresstest.c
@@ -385,15 +385,18 @@ int main(int argc, char **argv)
 			break;
 		case 'b':
 			info.arg_index += 2;
-			info.buffer_size = atoi(info.argv[info.arg_index]);
+			info.buffer_size = strtol(info.argv[info.arg_index], NULL, 10);
+			/* Max 4M */
+			if (info.buffer_size > (1024 * 1024 * 4))
+				info.buffer_size = 1024 * 1024 * 4;
 			break;
 		case 't':
 			info.arg_index +=2;
-			info.timeout = 1000 * atoi(info.argv[info.arg_index]);
+			info.timeout = 1000 * strtol(info.argv[info.arg_index], NULL, 10);
 			break;
 		case 'T':
 			info.arg_index +=2;
-			info.num_threads = atoi(info.argv[info.arg_index]);
+			info.num_threads = strtol(info.argv[info.arg_index], NULL, 10);
 			break;
 		case 'v':
 			if (!info.verbose)