retsnoop: build addr2line from the source. #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anakryiko
reviewed
Nov 9, 2021
ThinkerYzu1
force-pushed
the
resolve-sym-src-loc
branch
from
1af2506 to
c3ac151
Compare
anakryiko
reviewed
Nov 9, 2021
Use the source of the implementation of addr2line in the examples/ directory of gimli-rs to build a binary to keep tools/addr2line always update-to-date. Signed-off-by: Thinker Lee <[email protected]>
ThinkerYzu1
force-pushed
the
resolve-sym-src-loc
branch
from
c3ac151 to
a0a4391
Compare
|
I can't say I understand how this works, but I tried to make it work the way I was describing, and it didn't work :) You forgot to update .gitignore, but I'll just push it as a separate commit, no worries. Thanks for working on this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the source of the implementation of addr2line in the examples/
directory of gimli-rs to build a binary to keep tools/addr2line
always update-to-date.
Signed-off-by: Thinker Lee [email protected]