Enable portable cookie handling on iOS and Android.

[sebfia]

Made native cookie handling possible for iOS and Android, by introducing the NativeCookieHandler class instead of using the (strange) .NET CookieContainer. NativeCookieHandler is set to null by default in order to not break the current API.

[beeradmoore]

I don't think I am following this correctly, but how does adding the NativeCookieHandler to the NativeMessageHandler constructor do anything if you don't use the cookieHandler value for anything? Is more work needed to get this finished or is the fact that you are using NSHttpCookieStorage.SharedStorage and CookieManager that the native calls will just auto grab/store/use/update cookies in their own systems.

If that is the case does it even need to be in the constructor at all, wouldn't just having this object exist do the trick?

[anaisbetts]

the fact that you are using NSHttpCookieStorage.SharedStorage and CookieManager that the native calls will just auto grab/store/use/update cookies in their own systems.

^^ That one, he's using the Bait And Switch pattern, which reads a bit clever in diffs because you see dummy classes in the diff that never actually get used

[anaisbetts]

Also, I'm not sure why I missed this! Sorry @sebfia, I'll review this soon and get it merged

[beeradmoore]

Any reason to leave it in the constructor then?

[anaisbetts]

Thanks @sebfia!

[DavidPotter]

It look like the question about specifying it in the constructor never got answered. What does that do exactly? It looks like it is never referenced in the constructor, so why pass it in at all?

Also, is there an example of using the NativeCookieHandler class (ideally on iOS)?