Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove usage of six package #717

Merged
merged 24 commits into from
Aug 28, 2024
Merged

Conversation

mattkram
Copy link
Collaborator

The six library has been imported for a long time, as a result of the transition from python 2 -> 3. But we are way past that point, and anaconda-client already declares support for python<=3.8.

As a result, there is some dead code we can remove, all dependent on imports from six. This PR removes all references to six, and also removes some dead code which isn't referenced from anywhere inside the binstar_client package.

Copy link
Contributor

@AlbertDeFusco AlbertDeFusco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some pylint errors?

@mattkram
Copy link
Collaborator Author

I will need to re-think some of the removals here. Apparently anaconda-project has a dependency on this requests_ext module: https://github.com/anaconda/anaconda-project/blob/6968dda6e286e0a714fa85ec812df4e86e2d5136/anaconda_project/client.py#L129

@mattkram mattkram marked this pull request as draft August 28, 2024 03:59
@mattkram mattkram marked this pull request as ready for review August 28, 2024 14:02
@mattkram mattkram merged commit b9ba53f into anaconda:master Aug 28, 2024
16 checks passed
@mattkram mattkram deleted the chore/remove-six branch August 28, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants