Feature: TcpServer hot reload SSL file #353
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
an-tao
reviewed
Sep 9, 2024
| if (policyPtr_) { | ||
| sslContextPtr_ = newSSLContext(*policyPtr_, true); | ||
| } | ||
| } |
There was a problem hiding this comment.
感觉应该保证在loop_里执行，check一下是不是当前线程在loop_里，不是的话要queueInLoop一下。
There was a problem hiding this comment.
嗯，我改一下，不过我之前问了，chatgpt，说是在多线程的情况下，引用计数肯定是原子的，至于指针的赋值，可以保证不会出现无意义的数值，但是我也不确定，那就在loop里面吧，这样最少没错误的
There was a problem hiding this comment.
问题就是引用计数和指针赋值是两步，这两步不是原子的，sslContextPtr_在新连接建立的时候会被读，这是有竞态条件的。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While the TcpServer is running, reload the SSL from the file. New connections will use the new SSL, while existing connections will remain unchanged.