-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Work to refactor amuse.rfi #1078
Open
rieder
wants to merge
13
commits into
amusecode:main
Choose a base branch
from
rieder:refactor/rfi
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
2b8ba1d
remove (object) from classes
rieder 0d41725
improve pep8 compliance
rieder a5094d9
if not ... is None -> if ... is not None (etc)
rieder 57ad8af
reindent some text
rieder dd249af
simplify crc32 and reduce duplicate lines
rieder 647a5f4
replace '#~' comments with '#' comments
rieder 389515b
syntax updates to amuse.rfi
rieder bc83226
Merge branch 'main' into refactor/rfi
rieder 58e185b
Fix an oops
rieder b870fd8
remove (object) from class
rieder 57115b9
revised with Black and manual updates
rieder 6957c42
revised with Black and manual updates
rieder cc55137
not is None -> is not None
rieder File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does this code do? Is there anything affected by this?