Modified RuntimeError to NotFoundException in neo4j_proxy (metadata s… #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aparna-cimpress
requested review from
allisonsuarez,
bolkedebruin,
dorianj,
feng-tao,
jinhyukchang,
mgorsk1 and
verdan
as code owners
|
Linked with amundsen-io/amundsen#1027 PR. |
|
Hi @aparna-cimpress, thanks for the contribution. This generally LGTM, however, the Amundsen project moved to a monorepo. This sub-repository is now in read-only mode so that users with forks can have a smooth migration path (or if we find an urgent security issue that we want to backport), but new changes all need to go on the new monorepo, which is the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try block in
_put_resource_description&put_column_descriptionmethod throws RuntimeError when table or column doesn’t exist. I have changed it to throw NotFoundException with 404 status code.