This repository has been archived by the owner on Oct 23, 2022. It is now read-only.
fix: character '&' in xml documents #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
froucher
referenced
this pull request
May 18, 2020
`force-dev-tool changeset create` now handles properties of complex Metadata types. Complex Metadata types can contain other Metadata types (e.g. a `CustomObject` can contain a `CustomField`) - changing **independent** children was already handled by `force-dev-tool changeset create` by creating a deployment with only the `CustomField` instead of the whole `CustomObject`. However complex Metadata types can also have properties (e.g. a `CustomObject` has a `description`) and changing these properties was currently not handled. When changing the `description` of a `CustomObject` force-dev-tool now creates a deployment with the `CustomObject` but only containing the properties without the named/independent child Metadata components. The following exemplary changes should now be picked up correctly: - changing the `description` of a CustomObject/Profile - changing the `searchLayouts` of a CustomObject This PR introduces a brand new suite for functional testing of `force-dev-tool changeset create` and is based on simulating a Git history with typical changes to Metadata. See `test-functional/README.md` to get started. This closes #13, closes #90, closes #137.
|
Issue #243 |
new tests with '&' character
froucher
force-pushed
the
hotfix/ampersand
branch
from
17a1263 to
73e0f1a
Compare
|
🎉 This PR is included in version 2.7.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
It's about the conversion from
&to&, related to isaacs/sax-js#167 issue.The fix with
text = text.replace(new RegExp('&',"gm"), '&');doesn't not resolve any issue, even creates new bugs, if the metadata contains an unescaped&character then means that metadata is not the properly written.Added some tests with
&that ensure it is working right.Thanks