Skip to content
This repository has been archived by the owner on Oct 23, 2022. It is now read-only.

Feature/handle properties of complex metadata types #230

Merged
merged 35 commits into from
May 12, 2020
Merged

Feature/handle properties of complex metadata types #230

merged 35 commits into from
May 12, 2020

Conversation

froucher
Copy link
Contributor

@froucher froucher commented Apr 20, 2020 •
edited by amtrack
Loading

Todo List:

  • Compact Layout Fix
  • Add current changeset integration tests to functional tests
  • SearchLayout test
  • Add more tests
  • Move to general package.json
  • Optionally functional tests without deploy
  • README.md explaining how to work with functional tests
  • Create a test script for travis
  • ActionOverride test
  • More tests adding, updating, removing multiple metadata
  • Internal Tests
  • Remove some now redundant tests from test-integration
  • Run functional tests in CI

+@amtrack, thank you for your support!

froucher added 3 commits April 20, 2020 13:44
@froucher
test: new functional tests
bc1363b 
added first version of bdd tests
@froucher
feat: complex metadata types
ec49a85 
handle properties complex metadata types
@froucher
style: fixing lint errors
f38db0a
@froucher froucher marked this pull request as draft April 20, 2020 13:43
@froucher
refactor: remove test folders v0/src v1/src
f66dc83 
Moving files from "v0/src/*" to "v0/" and from  "v1/src/*" to " v1/"
@froucher froucher mentioned this pull request Apr 21, 2020
Closed
@froucher froucher force-pushed the feature/handle-properties-of-complex-metadata-types branch from 8f72894 to 723f8bd Compare April 27, 2020 13:03
@froucher froucher force-pushed the feature/handle-properties-of-complex-metadata-types branch from 538c4eb to 428593e Compare April 27, 2020 18:39
froucher added 15 commits April 28, 2020 11:09
@froucher
test: added tests with searchLayout
a228d8c
@froucher
fix: businessProcess is an indenpendent deployable child
0e5cf4e
@froucher
test: removed invalid duplicated test
00bcb39
@froucher
fix: sharingReason is an independent deployable child
02740f6
@froucher
test: cleaning examples in scenarios outlines
b90419b
@froucher
fix: when parent and deployable child are updated
4259914
@froucher
test: more tests when parent and child are updated
4861e1d
@froucher
test: option to skip deploy
4062435
@froucher
test: 'skipped' test is improved
6c6479f
@froucher
chore: added npm scripts
d10c715
@froucher
docs: added README.md for functional tests
f89d5cc
@froucher
style: fixing some lint issues
984c5e0
@froucher
chore: adding test:functional script to npm test command
96794a7
@froucher
chore: fixing travis issue
c31ace8 
Invalid: lock file's [email protected] does not satisfy tmp@^0.1.0
@froucher
test: fixing upper case definition searchLayout
c64a68f
@froucher froucher force-pushed the feature/handle-properties-of-complex-metadata-types branch from 31d973b to fb59643 Compare May 5, 2020 16:46
@froucher froucher marked this pull request as ready for review May 6, 2020 14:52
@amtrack
Copy link
Owner

amtrack commented May 9, 2020

@froucher This looks really really good! 😮 ❤️

I just did a first round of review and will continue soon.
You can cherry-pick from this branch https://github.com/amtrack/force-dev-tool/commits/feature/handle-properties-of-complex-metadata-types if you want.

@amtrack
Copy link
Owner

amtrack commented May 10, 2020

@froucher I've continued my review and pushed some more commits to my feature/handle-properties-of-complex-metadata-types branch, please cherry-pick or merge.

Besides those commits, I think this PR can be merged.

For debugging, running the test suite with npm run test:functional:doing and changing into the temp directory which is git controlled is a game changer!!! 🎆

Well done! 👏 🙏

This was referenced May 12, 2020
Closed
Closed
@froucher
Copy link
Contributor Author

Good job @amtrack! 👏 👍

Commits has been cherry-picked and travis continues green!

Thank you.

@froucher froucher force-pushed the feature/handle-properties-of-complex-metadata-types branch from afb252b to c926051 Compare May 12, 2020 09:22
@froucher froucher force-pushed the feature/handle-properties-of-complex-metadata-types branch from c926051 to 332ea58 Compare May 12, 2020 09:24
@amtrack amtrack merged commit ea74ef4 into amtrack:master May 12, 2020
@amtrack
Copy link
Owner

amtrack commented May 12, 2020

🎉 This PR is included in version 2.6.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@amtrack
Copy link
Owner

amtrack commented May 12, 2020

@froucher ¡Muchas gracias!
This is really great work!

@amtrack amtrack mentioned this pull request May 22, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@amtrack amtrack amtrack left review comments

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@froucher @amtrack