Fix pagination in AMP-compatible tab of plugins list page. #6681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
Plugin builds for af471e6 are ready 🛎️!
|
westonruter
reviewed
Nov 3, 2021
src/Admin/AmpPlugins.php
Outdated
| @@ -274,7 +274,7 @@ public function filter_plugins_api( $response, /** @noinspection PhpUnusedParame | |||
| $response->info = [ | |||
| 'page' => $page, | |||
| 'pages' => $total_page, | |||
| 'results' => count( $plugins ), | |||
| 'results' => count( $this->get_plugins() ), | |||
There was a problem hiding this comment.
Oh, I see what I did wrong when I changed this. I didn't account for $plugins being overridden. Ooops.
westonruter
approved these changes
Nov 3, 2021
westonruter
deleted the
enhancement/2313-highlight-amp-compatible-theme-plugin
branch
|
QA Passed Pagination works as expected on Add Plugins screen's "AMP Compatible" tab: Tested on AMP Version 2.2.0-alpha-20211123T020732Z-5405daa |
westonruter
added
the
Changelogged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related: #2313
Amends: #6597
Checklist