For images, don't raise a validation error for loading="lazy" or decoding="async" #3940
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
For images, this prevents validation errors if
loading="lazy"
ordecoding="async"
, but raises an error for any other value. Uses Weston's snippet in #3938 (comment).Fixes #3938
Using Weston's testing snippet in a Custom HTML block:
...there is now only a validation error for
loading="eager"
, notdecoding="async"
:And there's no validation error for
<img decoding="async" loading="lazy" ...>
, though those aren't copied into the<amp-img>
:Sanitization behavior
<img>
attribute<amp-img>
?loading
lazy
loading
lazy
, likeeager
decoding
async
decoding
async
, likesync
Checklist