Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace oneBehindFetch with cross-fetch in validator-rules #389

Merged
merged 1 commit into from
Jul 12, 2019
Merged

Replace oneBehindFetch with cross-fetch in validator-rules #389

merged 1 commit into from
Jul 12, 2019

Conversation

fstanis
Copy link
Collaborator

@fstanis fstanis commented Jul 11, 2019

It seems the current solution with oneBehindFetch has some odd behavior here. Since this is temporary anyway (#378), just replacing it with cross-fetch should work.

@fstanis fstanis requested a review from sebastianbenz July 11, 2019 16:31
@sebastianbenz
Copy link
Collaborator

Please use node-fetch instead. cross-fetch means just more dependencies without providing any value (as long as we don't build a bundled version for the browser).

@sebastianbenz
Copy link
Collaborator

Actually, I'm not sure if my comment is correct. Users of the library could probably create a bundle on their own.

@fstanis fstanis merged commit 8a65a02 into ampproject:master Jul 12, 2019
@fstanis fstanis deleted the validator-fix branch July 12, 2019 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastianbenz sebastianbenz sebastianbenz approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fstanis @sebastianbenz @googlebot