Removed GCM Service Account rule #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lae
requested changes
Feb 16, 2025
There was a problem hiding this comment.
Can you remove the rule from configs/secrets.list too?
So just as a quick rundown, this repository contains rule definitions but the existence of their files in here doesn't define their addition into a ruleset. The files in configs/ do (which were originally generated by looking up registry rulesets) which are read from to identify which rule files to include in the ruleset file (rules.json) that gets published in the latest GitHub release.
lae
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal to remove the GCM Service Account detection rule (
generic/secrets/security/detected-google-gcm-service-account.yaml).This rule generates a lot of FPs due to triggering on anything that matches the pattern
service_account:. In and of itself, a GCM service account is not a "secret." I suggest removing this rule to improve detection signal quality.