fix: Correct @djs/opus version restrictions #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In [node-semver](https://github.com/npm/node-semver#caret-ranges-123-025-004), the caret "Allows changes that do not modify the left-most non-zero element in the [major, minor, patch] tuple". That is, `0.x` versions are considered breaking, and thus not valid. I'm fairly sure this was just an oversight, as all `0.x` versions of djs/opus to date have been non-breaking. This change just modifies the dependency version to allow all `0.x` versions, breaking at `1.0.0`
skick1234
added a commit
to distubejs/prism-media
that referenced
this pull request
Jul 28, 2023
commit 4ef1d6f Author: Amish Shah <[email protected]> Date: Mon Feb 27 15:56:49 2023 +0000 chore(Release): v1.3.5 commit 84eb054 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Feb 27 15:55:06 2023 +0000 build(deps): bump json5 from 2.2.1 to 2.2.3 (amishshah#112) Bumps [json5](https://github.com/json5/json5) from 2.2.1 to 2.2.3. - [Release notes](https://github.com/json5/json5/releases) - [Changelog](https://github.com/json5/json5/blob/main/CHANGELOG.md) - [Commits](json5/json5@v2.2.1...v2.2.3) --- updated-dependencies: - dependency-name: json5 dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 02628fe Author: dzlandis <[email protected]> Date: Mon Feb 27 07:52:00 2023 -0800 fix(Decoder): add check of chunk length (amishshah#110) commit 37b3d65 Author: Chase Crayne <[email protected]> Date: Mon Feb 27 09:51:26 2023 -0600 Correct @djs/opus dependency version restrictions (amishshah#113) In [node-semver](https://github.com/npm/node-semver#caret-ranges-123-025-004), the caret "Allows changes that do not modify the left-most non-zero element in the [major, minor, patch] tuple". That is, `0.x` versions are considered breaking, and thus not valid. I'm fairly sure this was just an oversight, as all `0.x` versions of djs/opus to date have been non-breaking. This change just modifies the dependency version to allow all `0.x` versions, breaking at `1.0.0` commit fc562b1 Author: Amish Shah <[email protected]> Date: Sat Jul 9 12:01:26 2022 +0100 chore: run docs action on main branch commit fcd7ea6 Author: Amish Shah <[email protected]> Date: Sat Jul 9 11:58:14 2022 +0100 chore(Release): v1.3.4 (amishshah#106) * Update packages * Fix audit issues, replace docma, update tests * Update node in CI * Update README * Version bump to 1.3.4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In node-semver, the caret "Allows changes that do not modify the left-most non-zero element in the [major, minor, patch] tuple". That is,
0.xversions are considered breaking, and thus not valid. I'm fairly sure this was just an oversight, as all0.xversions of djs/opus to date have been non-breaking.This change just modifies the dependency version to allow all
0.xversions, breaking at1.0.0Fixes #109: