Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modified process_file() for a better "--no-overwrite" experience #51

Merged
merged 1 commit into from
Jan 6, 2019

Conversation

kai-modrzok
Copy link
Contributor

When I initially create contact-sheets in a video-folder the recursive functionality from vcsi works fine. But when I only want to create the contact-sheets for NEW videos - vcsi works not at it's best.

I can use the "--no-overwrite" mode, but it still parses the video. Also it find's the contact-sheets itself and tries to parse them as well (which results in errors). If I then use --ignore-errors it works better. But then I don't see errors anymore ;-)

So I slightly adjusted the process_file() method and moved the file check to the front of the method. Now i can just say "vcsi --no-overwrite ." in a folder over and over again and still get potential errors during contact-sheet generation.

now re-occurring recursive directory calls are faster and with less WARN-ings
@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 32.109% when pulling 73e6b28 on kai-modrzok:feature/recursive-enhancements into eb436cc on amietn:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 32.109% when pulling 73e6b28 on kai-modrzok:feature/recursive-enhancements into eb436cc on amietn:master.

@amietn
Copy link
Owner

amietn commented Jan 6, 2019

Thank you for contributing, much appreciated.

@amietn amietn merged commit 5816a45 into amietn:master Jan 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants