Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests for ModelToMjcf conversion and fix typo in MujocoCamera #336

Merged
merged 2 commits into from
Jan 10, 2025

Conversation

flferretti
Copy link
Collaborator

@flferretti flferretti commented Jan 10, 2025

This PR corrects the parameter name from azimut to azimuth in MujocoCamera and introduces unit tests to validate the ModelToMjcf conversion functionality.

Needs #335


📚 Documentation preview 📚: https://jaxsim--336.org.readthedocs.build//336/

@flferretti flferretti requested a review from xela-95 as a code owner January 10, 2025 15:32
@flferretti flferretti self-assigned this Jan 10, 2025
Copy link
Member

@xela-95 xela-95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @flferretti ! Unit tests are always welcome ;)

@flferretti flferretti force-pushed the visualizer_tests branch 3 times, most recently from 0afea1e to dab8c3f Compare January 10, 2025 15:51
@flferretti flferretti enabled auto-merge January 10, 2025 15:51
@flferretti flferretti merged commit 77f04c2 into main Jan 10, 2025
24 checks passed
@flferretti flferretti deleted the visualizer_tests branch January 10, 2025 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants