Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve variable naming in extract_model_data for readability #333

Merged
merged 1 commit into from
Jan 10, 2025
Merged

Improve variable naming in extract_model_data for readability #333

merged 1 commit into from
Jan 10, 2025

Conversation

flferretti
Copy link
Collaborator

@flferretti flferretti commented Jan 10, 2025 •
edited by github-actions bot
Loading

This PR renames a variable in the extract_model_data function for clarity

📚 Documentation preview 📚: https://jaxsim--333.org.readthedocs.build//333/

@flferretti flferretti requested a review from xela-95 as a code owner January 10, 2025 14:51
xela-95
xela-95 approved these changes Jan 10, 2025
View reviewed changes
Copy link
Member

@xela-95 xela-95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @flferretti !!

@flferretti flferretti self-assigned this Jan 10, 2025
@flferretti flferretti enabled auto-merge January 10, 2025 14:54
@flferretti flferretti merged commit 88d36a1 into main Jan 10, 2025
25 checks passed
@flferretti flferretti deleted the rename_variable_loader branch January 10, 2025 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xela-95 xela-95 xela-95 approved these changes

Assignees

@flferretti flferretti

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@flferretti @xela-95