Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make CartPole notebook runnable in colab #332

Merged
merged 3 commits into from
Jan 9, 2025
Merged

Conversation

younik
Copy link
Member

@younik younik commented Jan 9, 2025

The CartPole notebook assumed you have cloned the repo to have the URDF file already on disk.
I changed it to download the URDF file from this repo, similarly to what is done in other examples.


📚 Documentation preview 📚: https://jaxsim--332.org.readthedocs.build//332/

@flferretti
Copy link
Collaborator

Hi @younik! Thanks a lot for your contribution! For an easier development, I suggest you to install the pre-commit hooks with pre-commit install. This will run the same checks that are in CI for each commit. You can find more info in the Contributing Guide

Copy link
Collaborator

@flferretti flferretti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, LGTM!

@flferretti flferretti merged commit 5a59751 into ami-iit:main Jan 9, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants