-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add frame example #300
Add frame example #300
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @CarlottaSartore! LGTM. I just added a minor comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @CarlottaSartore for your contribution! I just left some minor comments.
Other than this, would you add a little unit test on the jaxsim.api.frame.velocity
function to avoid regressions in future? It can be added to https://github.com/ami-iit/jaxsim/blob/main/tests/test_api_frame.py
Co-authored-by: Alessandro Croci <[email protected]>
Co-authored-by: Filippo Luca Ferretti <[email protected]>
Co-authored-by: Alessandro Croci <[email protected]>
Thanks @xela-95, I have implemented the CI in 5fdbe5b Let me know if there ar any additional changes needed ! |
The tests are not passing, checking why |
I shoudl have fix with commit 436fde6 The error was that Jaxsim creates a single vector organise as : |
Right nice catch! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor typo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now it's good for me! :)
Co-authored-by: Filippo Luca Ferretti <[email protected]>
Thanks @xela-95, and @flferretti I should have also implemented your review, is it right ? can I proceed with the merge ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @CarlottaSartore, LGTM
This PR adds the example for computing velocity and transformation of the frames. In addition, it introduces minor changes to align the frames API with the link's one
📚 Documentation preview 📚: https://jaxsim--300.org.readthedocs.build//300/