-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uniform usage of joint_forces
and joint_force_references
argument names
#253
Conversation
ab7e46d
to
20f486c
Compare
Thanks @diegoferigo ! This will for sure help to clarify the usage of this argument. Just to be sure, have you also checked the use of jaxsim/src/jaxsim/api/contact.py Lines 128 to 133 in 7a2d193
jaxsim/src/jaxsim/api/contact.py Lines 94 to 99 in 7a2d193
compute_contact_forces methods of the different contact models (like rigid and relaxed_rigid) that use such input arguments?
|
I already checked them, let me know if you find mistakes :) I have a lot of changes pending, I might have missed something. |
b639c82
to
33ad625
Compare
I just noticed that I missed to commit two calls in the |
33ad625
to
07b3ece
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Diego, LGTM!
In short:
joint_forces
are the real joint forces that are set to the joint.joint_force_references
are the desired joint forces, that might differ from the real joint forces in presence of effects like joint friction.This PR updates the APIs making sure to use the right argument name so that it should be more clear to callers whether they might expect to lose a fraction of the passed joint force due to physical effects.
@flferretti @xela-95 please let me know if I missed something.