-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support reducing a model considering non-zero positions of removed joints #137
Conversation
4fc5fa3
to
3873b46
Compare
We only need to set the positions of the joints to remove. Passing the angles of the kept joints produces a wrong model with mismatching kinematics and collidable points.
9e63752
to
b968546
Compare
Tests are temporarily failing since they need a released version of iDynTree that includes robotology/idyntree#1180. |
This PR can be useful to both @flferretti and @YuchuanLu to compute the frame-to-parent-link transform In the future, we might consider to add a new |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Diego, LGTM!
jaxsim.api.model.reduce
with a newjoint_position_locked
dictionary that specifies the angles of the removed joints. Note that, if passed, it ignores the angles of the kept joints.KinematicGraph
to support joint angles (it calls the jax function to compute joint transforms).KinematicGraph
to a standalone class.jaxsim.math.joint_model.supported_joint_motion
cannot be jit-compiled dynamically over the joint type, it should slightly speed up compilation of RBDAs.KinematicGraph
fully implements theSequence
protocol.std::unordered_map<std::string, double>
to SWIG bindings robotology/idyntree#1180.📚 Documentation preview 📚: https://jaxsim--137.org.readthedocs.build//137/