Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new bresenham iterator that yield end point #292

Merged
merged 1 commit into from
Oct 4, 2022
Merged

Add new bresenham iterator that yield end point #292

merged 1 commit into from
Oct 4, 2022

Conversation

indubitablement2
Copy link
Contributor

@indubitablement2 indubitablement2 commented Aug 30, 2022 •
edited
Loading

  • Add advance method on Bresenham that return the next point without checking if we are past end. Bresenham iterator use this internally. It could also be used to create infinite line
  • Add BresenhamInclusive which is a wrapper over Bresenham that also return the end point
  • Add BresenhamInclusive to most tests

No breaking change

@thebracket
Copy link
Collaborator

This looks great - merging it. Thank you!

@thebracket thebracket merged commit 0660ce8 into amethyst:master Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@indubitablement2 @thebracket