Skip to content
This repository has been archived by the owner on May 3, 2024. It is now read-only.

[REFACTOR] PWA adapted to Fastify #857

Merged
merged 1 commit into from
Nov 28, 2022

Conversation

giulianok
Copy link
Member

Description

PWA changes needed to work with Fastify

Motivation and Context

The React HTML PR (https://github.com/americanexpress/one-app/pull/856/files#diff-49dfc5aceb91d68c288f11674343c97ac8f103f2da9f4e73ec6f2b4009d2a841) takes care of rendering the PWA app shell. These are the needed changes to make PWA work with React HTML app shell

How Has This Been Tested?

Manual, Unit Testing, Integration Test

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (adding or updating documentation)
  • Dependency update
  • Security update

Checklist:

  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • These changes should be applied to a maintenance branch.
  • This change requires cross browser checks.
  • Performance tests should be ran against the server prior to merging.
  • This change impacts caching for client browsers.
  • This change impacts HTTP headers.
  • This change adds additional environment variable requirements for One App users.
  • I have added the Apache 2.0 license header to any new files created.

What is the Impact to Developers Using One App?

@giulianok
Copy link
Member Author

@github-actions
Copy link
Contributor

github-actions bot commented Nov 9, 2022

Size Change: 0 B

Total Size: 681 kB

ℹ️ View Unchanged
Filename Size
./build/app/app.js 165 kB
./build/app/app~vendors.js 387 kB
./build/app/runtime.js 7.07 kB
./build/app/service-worker-client.js 7.26 kB
./build/app/vendors.js 114 kB

compressed-size-action

@@ -1,67 +0,0 @@
/*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this middleware deleted?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because it was moved into the react html plugin (see #856)

@giulianok giulianok merged commit c2f8c7d into feature/fastify-migration Nov 28, 2022
@giulianok giulianok deleted the refactor/pwa-plugin branch November 28, 2022 20:11
@giulianok giulianok mentioned this pull request Dec 5, 2022
14 tasks
@giulianok giulianok mentioned this pull request Mar 2, 2023
14 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants