Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export MakeValueWriter (#863) #864

Closed
wants to merge 1 commit into from
Closed

Conversation

barries
Copy link

@barries barries commented Nov 30, 2024

Issue #, if available: #863

Description of changes: Export MakeValueWriter

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

codecov bot commented Nov 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.81%. Comparing base (4e7431f) to head (148ed00).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #864   +/-   ##
=======================================
  Coverage   77.81%   77.81%           
=======================================
  Files         136      136           
  Lines       33984    33984           
  Branches    33984    33984           
=======================================
  Hits        26446    26446           
  Misses       5598     5598           
  Partials     1940     1940           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@zslayton zslayton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@zslayton
Copy link
Contributor

The build is complaining because several lints that were new in Rust 1.83 (just released) are failing. I've fixed those issues in PR #861, so I'll merge this after that.

@zslayton
Copy link
Contributor

zslayton commented Dec 3, 2024

Having thought on this a bit more, I decided to take this opportunity to split MakeValueWriter into two traits. Applications need access to the associated types, but shouldn't have access to the make_value_writer method. I've opened PR #867 to make this change. I'm going to close this as I believe #867 achieves the same thing more safely.

@zslayton zslayton closed this Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants