Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flesh out set/add macros/symbols #857

Merged
merged 3 commits into from
Nov 20, 2024

Conversation

jobarr-amzn
Copy link
Contributor

Issue #, if available: Contributes to #661

Description of changes: Defines set_macros, set_symbols, and add_symbols, as described in the Ion 1.1 spec.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jobarr-amzn jobarr-amzn requested a review from zslayton November 20, 2024 17:52
src/lazy/expanded/macro_evaluator.rs Show resolved Hide resolved
src/lazy/expanded/macro_evaluator.rs Outdated Show resolved Hide resolved
src/lazy/expanded/macro_evaluator.rs Outdated Show resolved Hide resolved
src/lazy/expanded/macro_table.rs Outdated Show resolved Hide resolved
src/lazy/expanded/macro_table.rs Outdated Show resolved Hide resolved
src/lazy/expanded/macro_table.rs Outdated Show resolved Hide resolved
src/lazy/expanded/macro_table.rs Outdated Show resolved Hide resolved
src/lazy/expanded/macro_table.rs Outdated Show resolved Hide resolved
ion-tests Outdated Show resolved Hide resolved
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.55%. Comparing base (36c3dca) to head (826e82a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #857      +/-   ##
==========================================
+ Coverage   77.27%   77.55%   +0.28%     
==========================================
  Files         135      135              
  Lines       33408    33796     +388     
  Branches    33408    33796     +388     
==========================================
+ Hits        25815    26210     +395     
+ Misses       5650     5645       -5     
+ Partials     1943     1941       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@jobarr-amzn jobarr-amzn merged commit d6cb3b4 into amazon-ion:main Nov 20, 2024
29 checks passed
@jobarr-amzn jobarr-amzn deleted the set-add-macros-symbols branch November 20, 2024 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants