Treat end-of-stream as a potential unstarted, incomplete value in StreamingRawReader #846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
popematt
force-pushed
the
input-fix-2
branch
2 times, most recently
from
570b0f2 to
771ff07
Compare
zslayton
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
amazon-ion/ion-cli#162
Description of changes:
Updates the
StreamingRawReaderto treat end-of-stream as a potential (not yet started) incomplete value.I have verified that this does actually fix the problem mentioned in amazon-ion/ion-cli#162.
This might be improved by separating the end-of-stream condition from the incomplete value condition so that we can find a way to discard the "non-value" data. That way we don't need to keep holding e.g. a 2000 word comment in memory just to read the next top-level value.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.