Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes the IonReader trait and its implementations. #752

Merged
merged 5 commits into from
Apr 24, 2024
Merged

Conversation

zslayton
Copy link
Contributor

The LazyReader is complete/spec-compliant, so we can now remove all of the legacy reader implementation machinery.

With the exception of a couple of unit test updates, there is no new code in this diff, only removals.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@zslayton zslayton changed the base branch from revert-serde-annotations to main April 24, 2024 20:58
@zslayton zslayton requested review from popematt and nirosys April 24, 2024 21:04
Copy link
Contributor

@desaikd desaikd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@zslayton zslayton merged commit 9c88ae7 into main Apr 24, 2024
32 checks passed
@zslayton zslayton deleted the rm-old-reader branch December 5, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants