Adds trait implementations #730
Conversation
| @@ -1494,7 +1494,7 @@ mod value_tests { | |||
| let list: Element = ion_list![1, 2, 3].into(); | |||
| thread::scope(|_| { | |||
| // Move `list` into this scope, demonstrating `Send` | |||
| let elements = vec![list]; | |||
| let elements = [list]; | |||
There was a problem hiding this comment.
🗺️ Clippy noticed that this vec! (and the associated heap allocation) is not necessary.
| @@ -38,46 +38,6 @@ pub trait AnnotatableValueWriter: Sized { | |||
|
|
|||
| /// Performs no operations and returns a [`ValueWriter`]. | |||
| fn without_annotations(self) -> Self::ValueWriter; | |||
|
|
|||
| // Users can call `ValueWriter` methods on the `AnnotatedValueWriter` directly. Doing so | |||
| // will implicitly call `without_annotations`. | |||
There was a problem hiding this comment.
🗺️ These default delegated methods mimicked those on ValueWriter, allowing users to call them on an AnnotatableValueWriter without first calling with_annotations or without_annotations. However, an AnnotatableValueWriter could not be passed to methods that required an implementation of ValueWriter.
| delegate_value_writer_to!(closure |self_: Self| { | ||
| self_.without_annotations() | ||
| }); | ||
| } |
There was a problem hiding this comment.
🗺️ The new blanket implementation of ValueWriter for all AnnotatableValueWriters.
| @@ -78,87 +78,3 @@ impl MakeValueWriter for Never { | |||
| } | |||
|
|
|||
| impl MacroArgsWriter for Never {} | |||
|
|
|||
| impl ValueWriter for Never { | |||
There was a problem hiding this comment.
🗺️ Never implements many traits so it can be used as a marker to statically indicate unreachable/unused code paths. Previously, Never implemented both ValueWriter and AnnotatableValueWriter; the new blanket impl allows us to eliminate the explicit implementation of ValueWriter.
Prior to this PR, the
AnnotatableValueWritertrait provided many of the same methods asValueWriterfor ergonomics. Calls to these methods were delegated to the type returned fromwithout_annotations().This patch reifies the relationship between
AnnotatableValueWriterandValueWriterby moving the delegated methods into a blanket implementation ofValueWriterfor allAnnotatableValueWriterimplementations. Existing uses of these methods continue to work as expected, but instances of anAnnotatableValueWriterimplementation can now also be passed into methods that expect animpl ValueWriter.The PR also adds
WriteAsIonimplementations for a variety of Rust int types.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.