Fixes ivm-after-nop in the lazy reader #708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zslayton
force-pushed
the
lazy-ivm-after-nop
branch
from
b40aa62 to
f46fe89
Compare
desaikd
approved these changes
Feb 12, 2024
Here's a small follow-on PR to address that: #710 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#706 fixed the raw binary reader (which is used in the
ion-cliandElementAPI) to allow it to recognize an IVM following a NOP pad. This PR makes the same change but for the lazy binary reader that will eventually replace the existing reader.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.