Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#672
Description of changes:
This PR modifies the
TemplateCompiler
to maintain afield_name
=>field_value_addresses
index for each template struct that it encounters. This allowsLazyStruct::find(name: &str)
to perform a singleHashMap
lookup any time its backing data is a template. If its backing data is a value literal, it will still need to perform a linear scan.Commit guide:
context
parameter from a fewMacroEvaluator
methods;MacroEvaluator
stores its owncontext
that can be used instead as needed.Here are some timings from of the included benchmark from my 2019 Intel MBP:
The same benchmarks, this time running on an
m5.4xlarge
:By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.