Update ion_debug_has_tracing to support strict function prototypes #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like tests failed for a couple of unrelated issues. Node20 is now default, which links to a newer version of glibc than is available on amazonlinux:1 & 2. The MacOS build failed, due to Xcode 14 being removed from the runner image. I'll follow up after this PR to fix the builds, but they have nothing to do with this PR. The ubuntu build & tests passed, and I've verified build and test on MacOS: Going to approve and merge! Thank you @drakumus! |
nirosys
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue 341
Description of changes:
Updates ion_debug_has_tracing declaration and definition to have a void parameter. This allows projects with strict prototyping enabled to include ion-c.