Fix documentation generation #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
popematt
approved these changes
Oct 25, 2023
linlin-s
approved these changes
Oct 25, 2023
cheqianh
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: N/A
Description of changes:
At some point in the past few months the documentation generation job stopped working due to permissions. This might be related to issues we had when we moved to the amazon-ion org, when org level permissions changed, I'm not sure though.
This PR adds
content: writepermissions to the document generation Job, so that we can push doc changes.Github now supports publishing to github pages via actions, an alternative to pushing to gh-pages branch, which might be worth looking into in order to see pros/cons, it feels gross to allow write access to a repo via GHA.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.