Allow creation of chatSession from startChatResponse parameters #286
+19
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added chatSessionParameters to ChatInterface and check for parameters in initiateChat
wue148070
requested review from
haomingli2020 and
agarwhi
and removed request for
a team
src/components/Chat/ChatInitiator.js
Outdated
| @@ -32,6 +32,9 @@ function safeParse(jsonString, defaultValue) { | |||
| * @returns {Promise} Promise object that resolves to chatDetails objects | |||
| */ | |||
| export function initiateChat(input) { | |||
| if (input.chatSessionParameters) { | |||
There was a problem hiding this comment.
- Instead of returning the
input.chatSessionParametershere, can we add a check where this function is called in ChatContainer.js and avoid the initiateChat call? - Can you add a unit test case for the new path?
Thanks!
There was a problem hiding this comment.
- I have moved the check from ChatInitiator.js to ChatContainer.js
- I have added a unit test to ChatContainer.test.js that checks that initiateChat has not been called when chatSessionParameters is present.
haomingli2020
approved these changes
Feb 26, 2025
agarwhi
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Added chatSessionParameters to ChatInterface.js that would be obtained by a call to startChatApi. If chatSessionParameters are present, initiateChat skips making a call to the provided backend startChat API and creates a chat session directly with the provided parameters.
Changes were built and the amazon-connect-chat-interface.js was tested locally on our website.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.