Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Use hybrid_job from braket.jobs #66

Merged
merged 3 commits into from
Mar 4, 2025
Merged

Conversation

rmshaffer
Copy link
Contributor

Issue #, if available:

Description of changes:
Use hybrid_job decorator from braket.jobs module, now that amazon-braket/amazon-braket-sdk-python#1056 has been merged and released.

Testing done:
Tests updated and tox passes.

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have checked that my tests are not configured for a specific region or account (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@rmshaffer rmshaffer requested a review from a team as a code owner February 12, 2025 17:05
Copy link

codecov bot commented Feb 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (9a504b2) to head (715b7fd).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #66   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           49        48    -1     
  Lines         2081      1997   -84     
  Branches       239       228   -11     
=========================================
- Hits          2081      1997   -84     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yitchen-tim
Copy link
Contributor

Since hybrid_job was removed from auroqasm, do we still need tests for the hybrid job? We actually don't test anything autoqasm in the unit tests.

@rmshaffer
Copy link
Contributor Author

Since hybrid_job was removed from auroqasm, do we still need tests for the hybrid job? We actually don't test anything autoqasm in the unit tests.

Good point. I don't know why I didn't remove the tests also. Will remove them.

@rmshaffer rmshaffer merged commit adc37a2 into main Mar 4, 2025
15 checks passed
@rmshaffer rmshaffer deleted the rmshaffer/hybrid-job branch March 4, 2025 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants