Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Org-habit-style min/max ranges in repeaters are not parsed correctly #17

Merged
merged 4 commits into from
Jan 6, 2025

Conversation

bgro
Copy link
Contributor

@bgro bgro commented Jan 3, 2025

Proposes a fix for #16.

@amake
Copy link
Owner

amake commented Jan 3, 2025

You've added support for e.g. +1w/+2w but by my reading of the documentation it should be +1w/2w (no repeater mark after the /). The relevant org-habit source appears to be here.

Is this intentional?

@amake
Copy link
Owner

amake commented Jan 3, 2025

I've pushed some fixes and improvements. Please check if my changes match your intentions.

@amake
Copy link
Owner

amake commented Jan 5, 2025

@bgro If you don't have any feedback I will go forward with merging and cut a new release.

@amake amake merged commit 7315578 into amake:master Jan 6, 2025
1 check passed
@bgro
Copy link
Contributor Author

bgro commented Jan 7, 2025

@amake I am terribly sorry for not responding -- I just noticed that github notifications only go to my work email address ... usually that is no problem, because I usually monitor that daily, but not during my vacations. I will change that immediately.

Thank you for the fast fix and the correction of my faulty proposal ... I had not read the spec carefully enough.

Kind regards, @bgro

@amake
Copy link
Owner

amake commented Jan 7, 2025

No need for apologies. Thanks for your contribution!

If you use Orgro you will find this change included in v1.51.1, ready for testing now:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants