Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Public access to font bytes #14

Merged
merged 1 commit into from
Jul 30, 2024
Merged

Public access to font bytes #14

merged 1 commit into from
Jul 30, 2024

Conversation

romnn
Copy link
Contributor

@romnn romnn commented May 1, 2024

Thanks for your work on this crate!

I am using it with notan and due to different egui versions in my dependency tree the egui::FontData i get from font_data() does not have the right type.

This PR adds public access to the font bytes so i can construct the notan::egui::FontData myself with the correct type.

This change does not affect the current design but additionally enabled working with multiple egui versions.

Best, Roman

@amPerl
Copy link
Owner

amPerl commented Jul 30, 2024

Sounds good, thanks!

@amPerl amPerl merged commit 99771f5 into amPerl:main Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants