Don't ignore undefined keys in where clauses

Fixes balderdashy/sails#4639
alxndrsn · Mar 22, 2019 · 6f69538 · 6f69538
1 parent adae21f
commit 6f69538
Showing 1 changed file with 2 additions and 5 deletions.
diff --git a/lib/waterline/utils/query/private/normalize-where-clause.js b/lib/waterline/utils/query/private/normalize-where-clause.js
@@ -298,13 +298,10 @@ module.exports = function normalizeWhereClause(whereClause, modelIdentity, orm,
       // > here, we have to be more forgiving-- both for usability and backwards-compatibility.
 
 
-      //  ╔═╗╔╦╗╦═╗╦╔═╗  ╦╔═╔═╗╦ ╦╔═╗  ┬ ┬┬┌┬┐┬ ┬  ╦ ╦╔╗╔╔╦╗╔═╗╔═╗╦╔╗╔╔═╗╔╦╗  ┬─┐┬ ┬┌─┐
-      //  ╚═╗ ║ ╠╦╝║╠═╝  ╠╩╗║╣ ╚╦╝╚═╗  ││││ │ ├─┤  ║ ║║║║ ║║║╣ ╠╣ ║║║║║╣  ║║  ├┬┘├─┤└─┐
-      //  ╚═╝ ╩ ╩╚═╩╩    ╩ ╩╚═╝ ╩ ╚═╝  └┴┘┴ ┴ ┴ ┴  ╚═╝╝╚╝═╩╝╚═╝╚  ╩╝╚╝╚═╝═╩╝  ┴└─┴ ┴└─┘
-      // Strip out any keys with undefined values.
+      // Convert undefined keys to null
       _.each(_.keys(branch), function (key){
         if (_.isUndefined(branch[key])) {
-          delete branch[key];
+          branch[key] = null;
         }
       });