Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

only the last disconnected session is remembered when (ement-save-sessions) is set to t #243

Open
formula-spectre opened this issue Nov 26, 2023 · 2 comments · May be fixed by #314
Open

only the last disconnected session is remembered when (ement-save-sessions) is set to t #243

formula-spectre opened this issue Nov 26, 2023 · 2 comments · May be fixed by #314
Assignees
@alphapapa
Labels
bug Something isn't working priority:A
Milestone
v0.17

Comments

@formula-spectre
Copy link

formula-spectre commented Nov 26, 2023 •
edited
Loading

OS/platform

Linux

Emacs version and provenance

GNU Emacs 30.0.50 (build 1, x86_64-gentoo-linux-musl, GTK+ Version 3.24.38, cairo version 1.18.0) of 2023-11-26
it comes from the official gentoo-linux repo; emerge =app/editors-emacs

Emacs command

emacsclient -c

Emacs frame type

both nox and GUI

Ement package version and provenance

ement version 0.13; taken via straight.el from github

Actions taken

I tried to connect to my primary account via ement-connect; then I eval'ed (ement-connect :uri-prefix "http://localhost:8008") (where 8008 is the port where pantalaimon is running on), to connect to my private account.

Observed results

after calling ement-disconnect on both accounts, and re-calling ement-connect, it remembers only the last session I disconnected from, e.g. if I use ement-disconnect RET account1 ement-disconnect RET account2 then ement-connect it will only remember the last one.

Expected results

I swear that when I had this set up for the first time with two accounts there was a pop-up that let you choose which account to use;
the expected result is that after calling ement-connect it should have a prompt giving you all the session you've been logged

Backtrace

No response

Etc.

I tried on both doom emacs and vanilla emacs, and the result was the same; I can attach the exact same step that I did on both side if it's needed, just let me know if that would be useful.
@formula-spectre formula-spectre added the bug Something isn't working label Nov 26, 2023
@alphapapa
Copy link
Owner

Thanks.

GNU Emacs 30.0.50 (build 1, x86_64-gentoo-linux-musl, GTK+ Version 3.24.38, cairo version 1.18.0) of 2023-11-26

Please always be sure to mention up front when you are using unreleased versions of Emacs or other software. It may not be relevant for this issue, but you should always do so--otherwise there's little reason to use unreleased versions, and it may waste time chasing bugs caused by upstream changes.

@alphapapa alphapapa added this to the 0.14 milestone Nov 26, 2023
@formula-spectre
Copy link
Author

sorry! but I can switch to emacs 29 if that can help in pinning down the bug no problem!

@alphapapa alphapapa modified the milestones: 0.14, 0.15 Jan 25, 2024
@alphapapa alphapapa modified the milestones: 0.15, 0.16 Mar 31, 2024
@alphapapa alphapapa modified the milestones: v0.16, v0.17 Aug 27, 2024
alphapapa added a commit that referenced this issue Oct 13, 2024
@alphapapa
Fix: Persist session data for reconnect
e7acf29 
When disconnecting from a session, we now keep the slots necessary for
reconnecting, and we persist those slots.

Previously all of the session's data was discarded after writing, so
if multiple accounts were disconnected but not at the same time, the
first session to be disconnected was forgotten.

Fixes #243.

Reported-by: formula-spectre <https://github.com/formula-spectre>
alphapapa added a commit that referenced this issue Oct 13, 2024
@alphapapa
Fix: Persist session data for reconnect
0f17741 
When disconnecting from a session, we now keep the slots necessary for
reconnecting, and we persist those slots.

Previously all of the session's data was discarded after writing, so
if multiple accounts were disconnected but not at the same time, the
first session to be disconnected was forgotten.

Fixes #243.

Reported-by: formula-spectre <https://github.com/formula-spectre>
alphapapa added a commit that referenced this issue Oct 13, 2024
@alphapapa
Fix: Persist session data for reconnect
e21e0bc 
When disconnecting from a session, we now keep the slots necessary for
reconnecting, and we persist those slots.

Previously all of the session's data was discarded after writing, so
if multiple accounts were disconnected but not at the same time, the
first session to be disconnected was forgotten.

Fixes #243.

Reported-by: formula-spectre <https://github.com/formula-spectre>
alphapapa added a commit that referenced this issue Oct 13, 2024
@alphapapa
Fix: Persist session data for reconnect
c8e774e 
When disconnecting from a session, we now keep the slots necessary for
reconnecting, and we persist those slots.

Previously all of the session's data was discarded after writing, so
if multiple accounts were disconnected but not at the same time, the
first session to be disconnected was forgotten.

Fixes #243.

Reported-by: formula-spectre <https://github.com/formula-spectre>
alphapapa added a commit that referenced this issue Oct 13, 2024
@alphapapa
Fix: Persist session data for reconnect
028c7e6 
When disconnecting from a session, we now keep the slots necessary for
reconnecting, and we persist those slots.

Previously all of the session's data was discarded after writing, so
if multiple accounts were disconnected but not at the same time, the
first session to be disconnected was forgotten.

Fixes #243.

Reported-by: formula-spectre <https://github.com/formula-spectre>
alphapapa added a commit that referenced this issue Oct 13, 2024
@alphapapa
Fix: Persist session data for reconnect
7f6032a 
When disconnecting from a session, we now keep the slots necessary for
reconnecting, and we persist those slots.

Previously all of the session's data was discarded after writing, so
if multiple accounts were disconnected but not at the same time, the
first session to be disconnected was forgotten.

Fixes #243.

Reported-by: formula-spectre <https://github.com/formula-spectre>
alphapapa added a commit that referenced this issue Oct 13, 2024
@alphapapa
Fix: Persist session data for reconnect
06e04a5 
When disconnecting from a session, we now keep the slots necessary for
reconnecting, and we persist those slots.

Previously all of the session's data was discarded after writing, so
if multiple accounts were disconnected but not at the same time, the
first session to be disconnected was forgotten.

Fixes #243.

Reported-by: formula-spectre <https://github.com/formula-spectre>
alphapapa added a commit that referenced this issue Oct 13, 2024
@alphapapa
Fix: Persist session data for reconnect
e1d1103 
When disconnecting from a session, we now keep the slots necessary for
reconnecting, and we persist those slots.

Previously all of the session's data was discarded after writing, so
if multiple accounts were disconnected but not at the same time, the
first session to be disconnected was forgotten.

Fixes #243.

Reported-by: formula-spectre <https://github.com/formula-spectre>
@alphapapa alphapapa linked a pull request Oct 13, 2024 that will close this issue
Draft
alphapapa added a commit that referenced this issue Oct 13, 2024
@alphapapa
Fix: Persist session data for reconnect
88d3b44 
When disconnecting from a session, we now keep the slots necessary for
reconnecting, and we persist those slots.

Previously all of the session's data was discarded after writing, so
if multiple accounts were disconnected but not at the same time, the
first session to be disconnected was forgotten.

Fixes #243.

Reported-by: formula-spectre <https://github.com/formula-spectre>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alphapapa alphapapa

Labels
bug Something isn't working priority:A
Projects
None yet
Milestone
v0.17
Development

Successfully merging a pull request may close this issue.

Wip/fix 243 session saving alphapapa/ement.el
2 participants
@alphapapa @formula-spectre