Don't rely on governmentpaas/awscli to build octodns container #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since boto/boto3#2596, we can't just pip3 install boto3 on top of it. The image we use comes from this PaaS repository: https://github.com/alphagov/paas-docker-cloudfoundry-tools/blob/main/awscli/Dockerfile which pins awscli to 1.17.2. This commit uses 1.18.140 which shouldn't have the issue. Also, use curl-ssl from GHCR instead of DockerHub.
Krenair
requested review from
chrisfarms,
philandstuff,
risicle,
cbaines and
szd55gds
|
We might want to do alphagov/paas-docker-cloudfoundry-tools#202 instead if we can. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since boto/boto3#2596, we can't just pip3 install
boto3 on top of it. The image we use comes from this PaaS repository:
https://github.com/alphagov/paas-docker-cloudfoundry-tools/blob/main/awscli/Dockerfile
which pins awscli to 1.17.2. This commit uses 1.18.140 which shouldn't have the issue.
Also, use curl-ssl from GHCR instead of DockerHub.