Fix missing date_parser require #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have some classes used by the rails app inside of lib. Controllers explicitly require these classes but in this case the AnonymousFeedbackController didn’t. This was causing an error when running locally, but doesn’t surface on deployed environments because they run in production mode which will eager load. In lieu of refactoring to put these classes in the app folder, this just updates the controller to require the DateParser class.
|
Looks good, thanks for fixing! |
|
Awesome! Thanks for checking @NeilVB (Cc @theleebriggs) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have some classes used by the rails app inside of lib. Controllers
explicitly require these classes but in this case the AnonymousFeedbackController
didn’t.
This was causing an error when running locally, but doesn’t surface on
deployed environments because they run in production mode which will
eager load.
In lieu of refactoring to put these classes in the app folder, this just
updates the controller to require the DateParser class.