Skip to content

Commit

Permalink
Upgrade Ruby to version 3.3.6
Browse files Browse the repository at this point in the history
* Drop support for Ruby 3.1
  • Loading branch information
unoduetre committed Dec 27, 2024
1 parent 39e12e5 commit da4eb4b
Show file tree
Hide file tree
Showing 6 changed files with 9 additions and 5 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
strategy:
fail-fast: false
matrix:
ruby: [3.1, 3.2, 3.3]
ruby: [3.2, 3.3]
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
Expand Down
2 changes: 1 addition & 1 deletion .ruby-version
Original file line number Diff line number Diff line change
@@ -1 +1 @@
3.1.5
3.3.6
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
# Unreleased

* Drop support for Ruby 3.1, keep supporting Ruby 3.2, use Ruby 3.3 as default https://github.com/alphagov/rails_translation_manager/pull/78

# 1.7.0

* Drop support for Ruby 3.0
Expand Down
2 changes: 1 addition & 1 deletion rails_translation_manager.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ Gem::Specification.new do |spec|
spec.homepage = ""
spec.license = "MIT"

spec.required_ruby_version = ">= 3.1"
spec.required_ruby_version = ">= 3.2"
spec.files = `git ls-files -z`.split("\x0")
spec.executables = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
spec.test_files = spec.files.grep(%r{^(test|spec|features)/})
Expand Down
2 changes: 1 addition & 1 deletion test/rails_translation_manager/exporter_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ def setup

data = read_csv_data(exported_file("fr.csv"))
assert_equal ["French", nil], data["language_names.fr"]
assert_equal nil, data["language_names.es"], "language key for spanish should not be present"
assert_nil data["language_names.es"], "language key for spanish should not be present"
end

test 'should export correct pluralization forms for target' do
Expand Down
2 changes: 1 addition & 1 deletion test/rails_translation_manager/yaml_writer_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ def teardown

DummyWriter.new.write_yaml(output_file, data)

assert_match /\n$/, File.readlines(output_file).last
assert_match (/\n$/), File.readlines(output_file).last
end

test 'strips whitespace from the end of lines for consistency with code editors' do
Expand Down

0 comments on commit da4eb4b

Please sign in to comment.