Replace title component with heading #2519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andysellick
force-pushed
the
use-heading
branch
from
c9d870e to
11e0fe1
Compare
- should still be a h1 and visually identical - heading has no margin top, so matches the previous margin_top: 0 option on title - title component is being retired and margin_top option has already been removed
andysellick
force-pushed
the
use-heading
branch
from
11e0fe1 to
f5c0769
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Replace the title component with the heading component.
Confession: I've not actually run this locally to check it visually, but I've done this in a lot of applications now and I'm reasonably confident it will work.
Why
The title component is being decommissioned and we've already removed the margin_top option from it as part of some other work. This means that with the latest changes a big space will suddenly appear above it. But if we switch it to the heading component, it looks exactly the same and won't have this problem.
Visual changes
None.
Trello card: https://trello.com/c/Y0pDWbHw/390-remove-margintop-option-from-shared-helper