Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore correct ordering for imported stylesheets #2516

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

davidtrussler
Copy link
Contributor

@davidtrussler davidtrussler commented Jan 27, 2025

Trello

When the "Add another" component is rendered in Publisher (e.g. on the "Related external links" tab) there was a problem if the standard (alphabetical) ordering of imported stylesheets was used whereby some styles specific to the component were over-written by more generic styles imported from the "Button" component. This affected the "Delete" button as shown in the screenshots below.

To get around this the stylesheets were imported in a different order so that styles for the "Add another" component were imported after the "Button" component. This has now been fixed in the Publishing Components gem so the stylesheets can be imported in alphabetical order.

The change in this PR restores the import order to an alphabetical listing now that the change in the component has been released.

Using the previous version of the Publishing Components gem Using the current version of the Publishing Components gem
Image Image

@davidtrussler davidtrussler marked this pull request as ready for review January 27, 2025 16:32
@davidtrussler davidtrussler merged commit 88bbe2f into main Jan 27, 2025
13 checks passed
@davidtrussler davidtrussler deleted the 587_Imported-stylesheet-ordering branch January 27, 2025 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants