PP-13377 show test payment notification on card payment screens #3945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- update charge retrieval middleware to make `isTestPayment` available to all views - show phase banner with test status when charge is for a test account - show notification banner on card input and confirmation screens when charge is for a test account
james-peacock-gds
requested changes
Jan 24, 2025
| @@ -85,7 +85,8 @@ | |||
| <div class="govuk-width-container govuk-main-wrapper"> | |||
| <div class="govuk-grid-row govuk-!-margin-bottom-9"> | |||
| <main class="charge-new govuk-grid-column-two-thirds" id="main-content" role="main"> | |||
| <div class="charge-new__content"> | |||
| {% include "includes/test-payment-notification-banner.njk" %} | |||
| <div class="charge-new__content"> | |||
There was a problem hiding this comment.
you've added a div here but you haven't added a closing tag - is that deliberate?
There was a problem hiding this comment.
this div is just moved, not removed?
There was a problem hiding this comment.
ha, yes clearly it is.
| cy.location('pathname').should('eq', `/card_details/${chargeId}`) | ||
| shouldCheckPhaseBanner() | ||
| shouldCheckNotificationBanner() | ||
| cy.task('clearStubs') |
There was a problem hiding this comment.
I think it would be easier to follow if there was a line break each time the stubs are cleared, but that may be a personal thing so I wouldn't hold it back for that reason
james-peacock-gds
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
isTestPaymentavailable to all viewsHOW
test-payment-notificationtest to see the difference between live and testSCREENS
LIVE (no change)
TEST (new banners)