[#140398377] Upgrade Terraform AWS provider #132
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the minimum upgrade required to fix an issue we are having with DNS entries flapping[1]. Documentation for this provider version: [2] [1] hashicorp/terraform-provider-aws#361 [2] https://github.com/terraform-providers/terraform-provider-aws/tree/v1.8.0/website/docs/r
henrytk
force-pushed
the
terraform-aws-provider-upgrade
branch
from
262aaae to
23991b9
Compare
henrytk
changed the title
|
After testing this against an old-style ELB (such as those in our persistent environments) it seems version 1.8.0 doesn't fix the problem. See https://www.pivotaltracker.com/story/show/140398377/comments/193676208 (private link). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This is the minimum upgrade required to fix an issue we are having with
DNS entries flapping[1].
[1] hashicorp/terraform-provider-aws#361
How to review
The short version: just code review, sanity check, and merge. This is because we pin versions of this image where it is consumed (paas-bootstrap and paas-cf), so it can be tested properly in those repositories.
Knowing this will work properly is tricky because our dev environments are not affected by this issue (hashicorp/terraform-provider-aws#361). They are not affected because they do not have the old versions of ELBs that cause the problems, whereas our persistent environments are running with old ELB versions, which are non-trivial to replace.
In theory, you could push an amended version of the staging deployer Concourse pipeline to pin this dev version, then verify by triggering the cf-terraform job and making sure it doesn't recreate the
aws_route53_record.apps_apexresource. However, manual fiddling with persistent environments is bad practice. Your call.To save you time I have run the bootstrap creation and deletion and paas-cf creation and deletion to ensure it at least doesn't break anything.
Who
Anyone but me