Upgrade itsdangerous #3314
Merged
Upgrade itsdangerous #3314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Version 1.1.0 has reverted the breaking change (moving from sha1 to sha256) that was introduced in version 1.0.0. Upgrading now so that we can take advantage of this bug fix: pallets/itsdangerous#46
|
This breaks the email-revalidation journey (and possibly email sign in). |
idavidmcdonald
previously approved these changes
Feb 21, 2020
quis
dismissed
idavidmcdonald’s stale review
We can’t upgrade this until we figure out why it’s breaking email re-validation
leohemsted
approved these changes
Feb 28, 2020
|
Going to test on preview. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version 1.1.0 has reverted the breaking change (moving from sha1 to sha256) that was introduced in version 1.0.0.
Upgrading now so that we can take advantage of this bug fix: pallets/itsdangerous#46
Closes #3308